Armageddon General Discussion Board

General => Code Discussion => Topic started by: Norcal on July 09, 2016, 02:48:11 PM

Title: We need nosell- noput and no give flags.
Post by: Norcal on July 09, 2016, 02:48:11 PM
I -hate- putting materials away in some crate and ending up tossing my skirt/cuirass/shirt or whatever else I am wearing that has the same keyword as what I am sorting, in the crate as well.    It happens to me quite often, and it is a pain to have to count the items in a bag that I want to store and makes sure I stop at that number.

The same is true when selling stuff and you accidently sell the container or a valued personal item. Or you give someone your shirt or skirt. Awkward rp moment there.

All this could be fixed with a no sell flag you could toggle on or off (like mercy or nosave). Then to sell, put or give any item occupying one of your PCs wear locations, you would have to remove the item first before you could give sell or put it.  That could be the message you receive as well "You must first remove <item>". Or "Not while you are wearing it".

Perhaps this exists already, and I am just unaware.  Yet if not,  this is a bit of code that would make a great difference.
Title: Re: We need nosell- noput and no give flags.
Post by: Malifaxis on July 09, 2016, 05:23:03 PM
Quote from: Norcal on July 09, 2016, 02:48:11 PM
I -hate- putting materials away in some crate and ending up tossing my skirt/cuirass/shirt or whatever else I am wearing that has the same keyword as what I am sorting, in the crate as well.    It happens to me quite often, and it is a pain to have to count the items in a bag that I want to store and makes sure I stop at that number.

The same is true when selling stuff and you accidently sell the container or a valued personal item. Or you give someone your shirt or skirt. Awkward rp moment there.

All this could be fixed with a no sell flag you could toggle on or off (like mercy or nosave). Then to sell, put or give any item occupying one of your PCs wear locations, you would have to remove the item first before you could give sell or put it.  That could be the message you receive as well "You must first remove <item>". Or "Not while you are wearing it".

Perhaps this exists already, and I am just unaware.  Yet if not,  this is a bit of code that would make a great difference.

I hate this too... I started using multiple keywords on almost everything.

And when dealing with multiples, it's always good to use 'put all.chalton.penis crate' or something.
Title: Re: We need nosell- noput and no give flags.
Post by: Clavis on July 10, 2016, 11:34:24 PM
tell me about it. Sucks sorting through a bunch of stuff, half paying attention. Go off and find yourself fighting without the armor you should be wearing, but aren't cause it was the first/second/third whatchaeverkeyword it got used for into a crate back at your home base.

would be great to keep breastplate whatever, and not accidently remove it place it in a crate and go out to get a spanking, by spider number 456.
Title: Re: We need nosell- noput and no give flags.
Post by: nessalin on January 13, 2017, 03:42:32 PM
Seen this in other games.

Recommended command/syntax?

change <object> [no_sell|no_give|no_drop]
Title: Re: We need nosell- noput and no give flags.
Post by: Miradus on January 13, 2017, 03:44:10 PM
Looks fine to me like that.
Title: Re: We need nosell- noput and no give flags.
Post by: chrisdcoulombe on January 13, 2017, 04:23:34 PM
Thats awesome
Title: Re: We need nosell- noput and no give flags.
Post by: puella on January 13, 2017, 04:25:52 PM
Looks like a good idea.  What about 'no_junk' too?
Title: Re: We need nosell- noput and no give flags.
Post by: bardlyone on January 13, 2017, 04:30:15 PM
Quote from: puella on January 13, 2017, 04:25:52 PM
Looks like a good idea.  What about 'no_junk' too?


yassssssssss
Title: Re: We need nosell- noput and no give flags.
Post by: wizturbo on January 13, 2017, 04:47:44 PM
This is one of those suggestions that I look at and wonder how the game ever existed without it.  Great idea.
Title: Re: We need nosell- noput and no give flags.
Post by: Samoa on January 13, 2017, 05:39:08 PM
Quote from: nessalin on January 13, 2017, 03:42:32 PM
Seen this in other games.

Recommended command/syntax?

change <object> [no_sell|no_give|no_drop]

I don't think it needs to have no in front of it -- after all, it's only 'no'd' half the time. change <object> [sell|give|drop] would be a bit less unwieldy, I think.
Title: Re: We need nosell- noput and no give flags.
Post by: bardlyone on January 13, 2017, 06:02:43 PM
maybe something as obvious as 'keep' like



keep lapis
Okay, you will now hold onto a lapis set doodad.
(Type keep again to be able to junk, drop, sell, or let go of a lapis set doodad.)


And if you attempted to sell/junk item, it might return


You are currently holding onto a lapis set doodad. Type keep again, to get rid of it.


Should probably be appended to drop, sell, pour, junk helpfiles, too, even if it's a different syntax, so that newbies and people not following the boards are aware of the command.
Title: Re: We need nosell- noput and no give flags.
Post by: Lizzie on January 13, 2017, 07:02:15 PM
I really like bardlyone's idea, to have "keep" be the command to make something unsellable/unjunkable/unputtable. A "no-keep" to switch it back.

Also if something like "keep" isn't doable, I'd much prefer the "change pants no-drop" to say you do NOT want to drop something - and then "change pants drop" to switch it to being droppable...than Samoa's idea of ditching the "no" part of it. There might be things that were toggled by their owner to be no-drop - and they're dead. And now you want their things, and need to switch them back. Or maybe you had something no-dropped and you change your mind at a later date. Keeping the "no" in when you do -not- want to do something, and then dropping the "no" when you do want to do something, is more intuitive.
Title: Re: We need nosell- noput and no give flags.
Post by: Incognito on January 14, 2017, 02:02:01 PM
Without going off on a derail, but on a related slightly-off-topic subject:

Code needs to be fixed to target items from top-to-bottom (in the worn list).

For example, you're wielding a knife and you're wearing a knife belt.
You <rem knife>
Instead of the EP'ed knife coming off, your knife belt comes off, causing your 2 sheathed weapons to end up in your inventory.

Another example:
You're wearing a black leather thong (on waist) and an obsidian shiv thong on your ankle.
You <rem thong>
Instead of the black leather thong (higher on the "wear pos" list) you end up removing the obsidian shiv thong on your ankle.

If this could be fixed, at the same time as the OP's suggestion, it'd be really great.
Title: Re: We need nosell- noput and no give flags.
Post by: Miradus on January 14, 2017, 02:09:10 PM

Something that has occurred to me regarding the no_put flag.

What happens when someone tries to steal an item out of your inventory with that flag? Or if you die and it becomes an item in the corpse?

Would there have to be a check on each item to see if those flags get reset?
Title: Re: We need nosell- noput and no give flags.
Post by: bardlyone on January 14, 2017, 03:33:07 PM
Quote from: Miradus on January 14, 2017, 02:09:10 PM

Something that has occurred to me regarding the no_put flag.

What happens when someone tries to steal an item out of your inventory with that flag? Or if you die and it becomes an item in the corpse?

Would there have to be a check on each item to see if those flags get reset?

I want to think that this would be different than the no_take flag that's on, say, obsidian deposits, and instead, merely disallow targeting of the item for give/put/drop/junk/pour commands, and as such, it wouldn't really have much/any impact on get/steal commands. I could be wrong.
Title: Re: We need nosell- noput and no give flags.
Post by: Molten Heart on January 14, 2017, 04:49:37 PM
.
Title: Re: We need nosell- noput and no give flags.
Post by: Molten Heart on January 14, 2017, 05:29:40 PM
.
Title: Re: We need nosell- noput and no give flags.
Post by: Malifaxis on January 14, 2017, 05:36:03 PM
Maybe I'm just an asshole, but I've always found that being careful is the best way to not put your shit somewhere that you don't want it to be.
Title: Re: We need nosell- noput and no give flags.
Post by: Hauwke on January 14, 2017, 07:51:00 PM
Ive personally only had the issue a few times, but I suspect that people who sort through storerooms may have it far more often. If its codable and easy to implement +1 if not eh whatever.
Title: Re: We need nosell- noput and no give flags.
Post by: Molten Heart on January 14, 2017, 08:17:07 PM
.